Fix URL processing in InternalLoad method #2487
Merged
baywet merged 5 commits intomicrosoft:mainfrom Sep 19, 2025
Merged
Conversation
Updated URL prefix checks to include colons for "http:" and "https:". Improved handling of file URLs by adding a check for the "file:" prefix to extract the local path. Adjusted format extraction logic to work with the new file name variable.
Contributor
Author
|
@microsoft-github-policy-service agree |
baywet
reviewed
Sep 19, 2025
This reverts commit 287abcc.
…on is thrown instead.
baywet
approved these changes
Sep 19, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+326
to
+333
| if (url.StartsWith("file:", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| fileName = new Uri(url).LocalPath; | ||
| } | ||
| else | ||
| { | ||
| fileName = url; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Allow file scheme URLs for Load
Strengthens checks of URI scheme and adjusts behavior to support file scheme. Falls back to pre-existing behavior otherwise